Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comprehensive docs for REFPROP interface #759

Closed
ibell opened this issue Aug 2, 2015 · 9 comments
Closed

Add comprehensive docs for REFPROP interface #759

ibell opened this issue Aug 2, 2015 · 9 comments
Milestone

Comments

@ibell
Copy link
Contributor

ibell commented Aug 2, 2015

No description provided.

@ibell ibell added this to the v5.1.2 milestone Aug 2, 2015
ibell added a commit that referenced this issue Aug 21, 2015
@ibell
Copy link
Contributor Author

ibell commented Aug 22, 2015

@mayersre Do you have any ideas for things we might want to add to the docs currently at http://www.coolprop.dreamhosters.com/binaries/sphinx/coolprop/REFPROP.html#refprop ? I think you are the most experienced CoolProp+REFPROP user

@mayersre
Copy link

sorry for the delay, but I move my home office currently ...

I like the documents from the link above and I like the alternative REFPROP path, it will help a lot when
experimenting with different binary pairs or using modern blends from dupont in calculation as it allows the usage of the duprex hmx.bnc file . I like the documentation on the low level interface even better ... I will try it in winter with my diagrams and some new nomographs and look what performance improvement can be gained.

@ibell
Copy link
Contributor Author

ibell commented Aug 24, 2015

Ok, glad you like them. If you have any ideas for things to put there, let
me know.

On Mon, Aug 24, 2015 at 3:57 AM, Reiner Mayers notifications@github.com
wrote:

sorry for the delay, but I move my home office currently ...

I like the documents from the link above and I like the alternative
REFPROP path, it will help a lot when
experimenting with different binary pairs or using modern blends from
dupont in calculation as it allows the usage of the duprex hmx.bnc file . I
like the documentation on the low level interface even better ... I will
try it in winter with my diagrams and some new nomographs and look what
performance improvement can be gained.


Reply to this email directly or view it on GitHub
#759 (comment).

@mayersre
Copy link

mayersre commented Nov 5, 2015

I run TestCoolprop.py code below

import CoolProp
print(CoolProp.__version__)
print(CoolProp.__gitrevision__)

import json, CoolProp.CoolProp as CP

jj = json.loads(CP.get_config_as_json_string())
jj['ALTERNATIVE_REFPROP_PATH'] = '/home/mayers/git/kformaug/extern/rp_nist/'
jj = CP.set_config_as_json_string(json.dumps(jj))

ref='REFPROP::R449A.MIX'
press=101325
bub_nist=CP.PropsSI('T','P',press,'Q',0,ref)-273.15
dew_nist=CP.PropsSI('T','P',press,'Q',1,ref)-273.15
print('{} Bubble point : {} Dew point {} at {} Pa.'.format(ref,bub_nist,dew_nist,press))

Output is fine

5.1.1dev
ccc012c31a7c1505f5399acfa5ab85f24f41fd8b
REFPROP::R449A.MIX Bubble point : -44.04775623435387 Dew point -38.05712164462065 at 101325 Pa.

or

5.1.2dev
851c961cd6e584c452489fd3ae668e6f03ef1da6
REFPROP::R449A.MIX Bubble point : -44.04775623435387 Dew point -38.05712164462065 at 101325 Pa.

But it does not take refprop from '/home/mayers/git/kformaug/extern/rp_nist/'

if I strace it, the output does not even contain 'nist'

strace -o x.out python TestCoolprop.py
grep nist x.out > nothing

@jowr
Copy link
Member

jowr commented Nov 5, 2015

Thanks for the comment. I am not sure how the path is handled on Linux, I think we only support Windows for now...

@mayersre , I edited your post and added fenced code blocks to make the source code easier to read.

@ibell
Copy link
Contributor Author

ibell commented Nov 5, 2015

Actually, I wrote the docs, but they are currently ahead of the code. I'll
fix the code soon I hope.
On Nov 5, 2015 12:17 PM, "Jorrit Wronski" notifications@github.com wrote:

Thanks for the comment. I am not sure how the path is handled on Linux, I
think we only support Windows for now...

@mayersre https://github.com/mayersre , I edited your post and added
fenced code blocks to make the source code easier to read.


Reply to this email directly or view it on GitHub
#759 (comment).

@ibell
Copy link
Contributor Author

ibell commented Nov 15, 2015

Can you try again? I updated the code. If it works, we can close the issue.

@mayersre
Copy link

That works nicely now on Linux. I cloned the repo, built coolprop by instruction from the website, installed it into my virtualenv (no sudo neccessary), re-ran the commands for refprop access from django --> success.
Coolprop Version : 5.1.2dev
Gitrevision : 08e2761

Switch ALTERNATIVE_REFPROP_PATH from rp_nist to rp_honeywell to rp_dupont --> success

Thanks 👍

@ibell
Copy link
Contributor Author

ibell commented Nov 15, 2015

Have you tried to use the path to the HMX.BNC file? Does that work for you? I think it should. For now, I am going to close this issue... Any further problems, please re-open. Any other recommendations for the docs, I'm game as well.

@ibell ibell closed this as completed Nov 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants