Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong series returned from _curve #12

Open
chen0040 opened this issue Oct 8, 2021 · 1 comment
Open

Wrong series returned from _curve #12

chen0040 opened this issue Oct 8, 2021 · 1 comment

Comments

@chen0040
Copy link

chen0040 commented Oct 8, 2021

There is some bug in https://github.com/EthicalML/xai/blob/master/xai/__init__.py#L962

it was written as

r1s = r2s = []

but should be instead

r1s, r2s = [], []

The impact is that if the user would like to us r1s and r2s returned to construct the the curve (e.g. for storing the data for later analysis), they would find that r1s and r2s are referring to the same instance which stores all the curve data that should have been separately stored in r1s and r2s

@axsaucedo
Copy link
Contributor

Interesting - thank you for flagging, would you be interested on opening a PR @chen0040 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants