Kubelet: parallelize cleaning up containers in unwanted pods #7048
Conversation
|
This addresses #6764 |
| wg.Add(1) | ||
| go func(container *kubecontainer.Container) { | ||
| defer util.HandleCrash() | ||
| // call the networking plugin for teardown |
There was a problem hiding this comment.
Can we add a TODO to handle this without singling our the pod infra container? Main motivation is for Rocket integration which does not have one. We're working on moving the pod infra to be a Docker-only concept.
|
Minor comments, looks good overall. Thanks @yujuhong! |
| for i, c := range pod.Containers { | ||
| containerIDs[i] = string(c.ID) | ||
| } | ||
| return kl.containerManager.GetRunningContainers(containerIDs) |
There was a problem hiding this comment.
Thought not related to this PR, but I always have a question about this, I am not sure why the running containers are necessary for removing volumes. I suspect that if the volume is still being used by some container, TearDown() will just return an error (such as device busy).I think if we can remove this logic, it would be great.
As I can remember, this is part of a fix for volume leaks, but I am not sure the original problem is caused by deleting alive volumes..
Let me find out the issue number...
There was a problem hiding this comment.
I believe that in theory we should be able to remove it and the volume plugins would handle it. However, it seems like we've had quite a few bugs in this area which lead to data loss. That is what has kept the current logic I believe.
|
LGTM, we can squash and merge |
Kubelet kills unwanted pods in SyncPods, which directly impact the latency of a sync iteration. This change parallelizes the cleanup to lessen the effect. Eventually, we should leverage per-pod workers for cleanup, with the exception of truly orphaned pods.
|
Squashed. Thanks! |
Kubelet: parallelize cleaning up containers in unwanted pods
Kubelet kills unwanted pods in SyncPods, which directly impact the latency of a
sync iteration. This change parallelizes the cleanup to lessen the effect.
Eventually, we should leverage per-pod workers for cleanup, with the exception
of truly orphaned pods.