Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/gce/coreos: Add metadata-service in node.yaml #7526

Merged
merged 1 commit into from Apr 30, 2015

Conversation

yifan-gu
Copy link
Contributor

/cc @dchen1107 @vmarmol @jonboulle @bakins

Actually I found the metadata service is already started in old node.yaml, just updated with more specific service/socket files.
This saves us from start metadata service manually in #7465

@vmarmol vmarmol self-assigned this Apr 29, 2015
@yifan-gu
Copy link
Contributor Author

Also this one uses the 0.5.4 version rkt metadata service.
Tested with kube-up.sh, looks good.
Let me run e2e.

@jonboulle
Copy link
Contributor

lgtm

@vmarmol
Copy link
Contributor

vmarmol commented Apr 29, 2015

LGTM, any reason to run them this way instead of how we did before?

@yifan-gu
Copy link
Contributor Author

@vmarmol One is we were not running the new version of rkt metadata service. Two is I think named service is more manageable. And three is it's now socket activated.

@vmarmol
Copy link
Contributor

vmarmol commented Apr 29, 2015

Did you get a chance to test btw? While we wait for Travis

@yifan-gu
Copy link
Contributor Author

@vmarmol Yes, I will run e2e

@vmarmol
Copy link
Contributor

vmarmol commented Apr 29, 2015

More than anything that the CoreOS cluster comes up :) @dchen1107 had the instructions in her PR

@yifan-gu
Copy link
Contributor Author

e2e agains gce/debian passed:

Ran 36 of 41 Specs in 1086.721 seconds
SUCCESS! -- 36 Passed | 0 Failed | 1 Pending | 4 Skipped I0429 16:19:02.608573   18082 driver.go:96] All tests pass
2015/04/29 16:19:02 Running: teardown
Starting cluster using os distro: debian
Project: coreos-gce-testing
Zone: us-central1-b
Shutting down test cluster in background.

build/push-devel-build.sh passed:

TOTAL: 30 objects, 692900767 bytes (660.8 MiB)

Running e2e agains gce/coreos

@zmerlynn
Copy link
Member

FWIW, don't worry too much about the push-devel-build part. I was merely pointing that out in her PR because of a breaking issue in the release flow I noticed there. In typical changes (i.e. not renaming a cluster/* file), it's not something you need to run.

@yifan-gu
Copy link
Contributor Author

@zmerlynn Sounds good! Thanks!

@yifan-gu
Copy link
Contributor Author

@vmarmol I can't pass e2e on coreos cluster yet, I think that's not related to this PR.

cc @bakins We haven't yet successfully passed e2e on coreos cluster yet, right?

@vmarmol
Copy link
Contributor

vmarmol commented Apr 30, 2015

Yeah I don't think we have :) there are some tests that are Docker-specific so I wouldn't expect them to pass just yet.

I think we're good with this PR, will merge. Thanks @yifan-gu!

@yifan-gu
Copy link
Contributor Author

Thanks @vmarmol !

vmarmol added a commit that referenced this pull request Apr 30, 2015
cluster/gce/coreos: Add metadata-service in node.yaml
@vmarmol vmarmol merged commit 5f83166 into kubernetes:master Apr 30, 2015
@yifan-gu yifan-gu deleted the metadata-service branch April 30, 2015 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants