Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RackCDN API now returns 201 - Created instead of 204 #26

Closed
jwrightecs opened this issue Jul 28, 2023 · 4 comments
Closed

RackCDN API now returns 201 - Created instead of 204 #26

jwrightecs opened this issue Jul 28, 2023 · 4 comments

Comments

@jwrightecs
Copy link
Contributor

The code in put / put_filename checks for response code 204 to set etag / size / content type, but the rackcdn api returns 201 which is more correct for a PUT

put and put_filename should check response.code == to 201 or 204
@Htbaa
Copy link
Owner

Htbaa commented Jul 28, 2023

Can you provide a pull request?

@jwrightecs
Copy link
Contributor Author

#27

@Htbaa
Copy link
Owner

Htbaa commented Aug 2, 2023

Has been merged.

@Htbaa Htbaa closed this as completed Aug 2, 2023
@Htbaa
Copy link
Owner

Htbaa commented Aug 2, 2023 •
edited
Loading

Versie 2.03 has been released. Currently being processed by CPAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Htbaa @jwrightecs