-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to create binary packages #1137
Conversation
Symlinks were created even when make install was called with a non-empty DESTDIR variable. Fixed by creating the symlinks in build directory first and then install them using common install. DESTDIR installation is needed for binary packages.
Can one of the admins verify this patch? |
for multiarch distributions the lib directory needs to changed from 'lib' to 'lib64'/'lib32'. Add an cmake option to do this.
test this please |
Is cmake_dir something which is a cmake standard or guideline? |
Tests Failed. |
The build failure is unrelated to the proposed changes. |
|
Makes sense. What I was wondering about was if we can't choose a more meaningful names for the variables and also have it documented properly. This might be helpful for other package maintainers as well. |
Done. |
improvements to create binary packages
Merged. Thanks for the improvements! |
3 fixes:
make install DESTDIR=XXX
work againlib
directory configure-ablecmake_dir
configure-able