Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to create binary packages #1137

Merged
merged 3 commits into from May 21, 2014
Merged

Improvements to create binary packages #1137

merged 3 commits into from May 21, 2014

Conversation

junghans
Copy link
Contributor

3 fixes:

  • make make install DESTDIR=XXX work again
  • make lib directory configure-able
  • make cmake_dir configure-able

@junghans
fix make install non-empty DESTDIR
5c04f9c 
Symlinks were created even when make install was called with a
non-empty DESTDIR variable. Fixed by creating the symlinks in build
directory first and then install them using common install.
DESTDIR installation is needed for binary packages.
@StellarBot
Copy link

Can one of the admins verify this patch?

@junghans
added LIB cmake option to configure lib directory
cef6ea5 
for multiarch distributions the lib directory needs to changed
from 'lib' to 'lib64'/'lib32'. Add an cmake option to do this.
@sithhell
Copy link
Member

test this please

@sithhell
Copy link
Member

Is cmake_dir something which is a cmake standard or guideline?
I am not sure if make install DESTDIR=xxx is working correctly. We use the CMAKE_INSTALL_PREFIX to compile some lookup paths into the library. This needs to be verified seperately from the currently running merge build

@StellarBot
Copy link

Tests Failed.
Refer to this link for build results: http://hermione.cct.lsu.edu:5632/job/hpx_pr_debug_gcc_44_boost_1_55_0/21/

@sithhell
Copy link
Member

The build failure is unrelated to the proposed changes.

@junghans
Copy link
Contributor Author

Is cmake_dir something which is a cmake standard or guideline?
These is no default, but /usr/share/cmake-VERSION/Modules is just odd. Most distribution don't come with multiple cmake versions, so it should be /usr/share/cmake/Modules by default.

@sithhell
Copy link
Member

Makes sense. What I was wondering about was if we can't choose a more meaningful names for the variables and also have it documented properly. This might be helpful for other package maintainers as well.

@junghans
Copy link
Contributor Author

Done.

sithhell added a commit that referenced this pull request May 21, 2014
@sithhell
Merge pull request #1137 from ottxor/master
eb5abfc 
improvements to create binary packages
@sithhell sithhell merged commit eb5abfc into STEllAR-GROUP:master May 21, 2014
@sithhell
Copy link
Member

Merged. Thanks for the improvements!

@hkaiser hkaiser added this to the 0.9.9 milestone May 22, 2014
@hkaiser hkaiser changed the title improvements to create binary packages Improvements to create binary packages May 27, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: CMake platform: Linux type: enhancement
Projects
None yet
Milestone
0.9.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@junghans @StellarBot @sithhell @hkaiser