Allowing to specify whether to send credits along with message #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| HPX_API_EXPORT void set_lco_error(naming::id_type const& id, | ||
| boost::exception_ptr && e, naming::id_type const& cont); | ||
| boost::exception_ptr && e, naming::id_type const& cont, | ||
| bool move_credits); |
There was a problem hiding this comment.
why do these miss the default parameter for move_credits?
Conflicts: hpx/runtime/actions/continuation.hpp
hkaiser
force-pushed
the
fixing_hpxcl_problem
branch
from
a99963b
to
bd92871
Compare
…ns into separate header
hkaiser
force-pushed
the
fixing_hpxcl_problem
branch
from
bd92871
to
5e9a46d
Compare
|
@Finomnis This should solve the issue. Please let us know whether we can go ahead and merge the changes to master. |
|
I confirm that this solved the issue. IMO this branch can get merged. |
hkaiser
added a commit
that referenced
this pull request
Jun 28, 2015
Allowing to specify whether to send credits along with message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing to specify whether to send credits along with message back to the future.
This has shown to fix the HPXCL problems (see comments on 42d15d3)