Fixing a problem with credit splitting as revealed by #1898 #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
We currently run into a situation where we would need to wait on futures before actual serialization after the first round of awaiting has been completed. In addition, the future itself doesn't give its held value the chance to be awaited.
sithhell
added a commit
that referenced
this pull request
Dec 9, 2015
Fixing a problem with credit splitting as revealed by #1898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently run into a situation where we would need to wait on futures before
actual serialization after the first round of awaiting has been completed. In
addition, the future itself doesn't give its held value the chance to be awaited.
This fixes the segfault on shutdown for the testcase provided by #1898 once all the remaining (user issues) has been fixed (this will come in a separate PR).