Sort by key example #1956
Merged
Sort by key example #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix for parallel sort compare_projected
…E_RVALUE_SWAP is not defined
|
LGTM |
|
I'm adding a test and fixing one thing I missed if called using par(task) or seq(task), so hold off merging a bit |
- touched up on documentation - adding supporting infrastructure to make_tagged_pair, etc. - fixing inspect errors reported for sort_by_key.cpp
|
I'm now using this final version and not having any problems. I think it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems to be working well. Ready to merge?