Fixing 1965 #1971
Merged
Fixing 1965 #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Except for the nitpick that you could add all command line options in one go: this looks good to me. Thanks! |
When run normally, the test will perform one extra benchmark test that outputs a time in a form compatible with CDash. When run with "--benchmark" commandline option then the usual unit tests are skipped and only the benchmark is run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has not passed CircleCi tests yet, but I'd like to merge it to master as soon as it does so that I can start collecting timings of sort/scan tests as soon as possible - to give a few baseline points on a timing graph before I modify the parallel sort algorithm, and/or possibly the scan implementation.