Turning assertions into exceptions #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hkaiser
commented
Jun 2, 2017
hkaiser
commented
- flyby: refactor future_serialization_save to reduce code duplication
hkaiser
force-pushed
the
fixing_future_serialization
branch
from
fd5a37b
to
19972e8
Compare
sithhell
reviewed
Jun 5, 2017
hpx/lcos/future.hpp
Outdated
| HPX_ASSERT(false); | ||
| HPX_THROW_EXCEPTION(invalid_status, | ||
| "serialize_future_load", | ||
| "attempting to deserialize a future with an invalid state"); |
There was a problem hiding this comment.
I think this should read "unknown state" as ´future_state::invalid` seems to be just fine.
hpx/lcos/future.hpp
Outdated
| HPX_ASSERT(false); | ||
| HPX_THROW_EXCEPTION(invalid_status, | ||
| "serialize_future_load", | ||
| "attempting to deserialize a future with an invalid state"); |
- flyby: refactor future_serialization_save to reduce code duplication
hkaiser
force-pushed
the
fixing_future_serialization
branch
from
19972e8
to
33ba6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.