-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace boost::atomic with std::atomic (where possible) #2782
Conversation
macro(hpx_check_for_cxx11_std_atomic) | ||
add_hpx_config_test(HPX_WITH_CXX11_ATOMIC | ||
SOURCE cmake/tests/cxx11_std_atomic.cpp | ||
LIBRARIES "-latomic" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't this get in the way on platforms not supporting libatomic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It somehow doesn't, but I don't really understand why that is the case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is fine as long as the compiler only warns for unknown arguments and doesn't fail if it can't find the library to link against.
baf4deb
to
f92abdc
Compare
7e1e084
to
7a1ff1a
Compare
@K-ballo should we go ahead and merge this - or are you looking for a solution to the |
7a1ff1a
to
a08615a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, Agustin! LGTM!
No description provided.