Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable throttling scheduler if HWLOC is not found/used #2809

Merged
merged 2 commits into from
Aug 9, 2017
Merged

Disable throttling scheduler if HWLOC is not found/used #2809

merged 2 commits into from
Aug 9, 2017

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Aug 9, 2017

@hkaiser
Disable throttling scheduler if HWLOC is not found/used
b8b2471 
- this is necessary as this scheduler directly uses HWLOC.
- this fixes #2807
@hkaiser hkaiser added this to the 1.1.0 milestone Aug 9, 2017
@hkaiser
Copy link
Member Author

hkaiser commented Aug 9, 2017

@bremerm31 this should fix the issue you reported, please verify.

@bremerm31
Copy link
Contributor

I'm getting the following error when trying to build:

https://gist.github.com/bremerm31/63d03bc7c528ff76e336c79a513ab776

@hkaiser
Copy link
Member Author

hkaiser commented Aug 9, 2017

Ok, so there is more to it then I thought. Let me investigate one more time.

@hkaiser
Copy link
Member Author

hkaiser commented Aug 9, 2017

@bremerm31 what about now? Thanks!

bremerm31
bremerm31 approved these changes Aug 9, 2017
View reviewed changes
Copy link
Contributor

@bremerm31 bremerm31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it to compile. Looks good to me.

@hkaiser hkaiser merged commit 5008c37 into master Aug 9, 2017
@hkaiser hkaiser deleted the fixing_2807 branch August 9, 2017 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bremerm31 bremerm31 bremerm31 approved these changes

Assignees
No one assigned
Labels
type: compatibility issue type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Difficulty building with HPX_WITH_HWLOC=Off
2 participants
@hkaiser @bremerm31