Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hpx::bind scatter/balanced give wrong pu masks #2880

Closed
biddisco opened this issue Sep 4, 2017 · 4 comments
Closed

hpx::bind scatter/balanced give wrong pu masks #2880

biddisco opened this issue Sep 4, 2017 · 4 comments

Comments

@biddisco
Copy link
Contributor

biddisco commented Sep 4, 2017

on a dual socket node with 18 cores per socket and 2 hyperthreads, there are 72 threads

--hpx::bind=balanced --hpx:threads=4

should give a pu mask

000000000000000000000000000000000000000000000101000000000000000000000000000000000000000000000101

but it actually gives

000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001010101

and in fact

--hpx::bind=scatter --hpx:threads=4

should give the same pu mask, but with a different thread numbering for each pu (0213 or 0123 depending on your choice).

@hkaiser
Copy link
Member

hkaiser commented Sep 4, 2017

--bind=balanced distributes threads across cores in a balanced way, not across sockets. From what I can see from the bitmasks - all is correct. This is not a bug.

@hkaiser hkaiser added this to the 1.1.0 milestone Sep 4, 2017
@biddisco
Copy link
Contributor Author

biddisco commented Sep 5, 2017

https://stellar-group.github.io/hpx/docs/html/hpx/manual/init/commandline/details.html
Shows the distribution - but it seems I misunderstood that these were cores only and not sockets/etc.

We need a distribution mode that allows pus to be assigned across numa-domains in a balanced or scattered way. It is not clear to me that the balanced/scatter modes are of any use in their current form. Can we simply redefine them or should we create new modes that give the distribution I would like?

@sithhell
Copy link
Member

sithhell commented Sep 5, 2017 via email

@biddisco
Copy link
Contributor Author

This was addressed by adding a numa balanced bind mode in #2900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants