-
-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify allocator rebinding in pack traversal #2981
Conversation
Thanks @K-ballo, let's go ahead and merge this as a stop-gap measure. @Naios would you have time to change the original code at some point? I think we could try replacing the offending
which might already solve the problem. |
In my opinion it would be better to conditionally disable the stateful allocator rebinding through the preprocessor if the intel compiler is used, instead of outcommenting the code for every toolchain. @K-ballo could you try to apply the possible workaround proposed by @hkaiser please? Let me know if I can help more on this. |
...workaround for Intel compiler bugs
@Naios Rostam has a working Intel compiler. You should probably already have access there, if not we can get you an account. |
@Naios the proposed workaround allows Intel to build core HPX, but it causes it to fail while building the |
@K-ballo circleci is not happy with this... it might not be possible to simply use the allocator_traits after all. |
@hkaiser That was caused by my latest commit. Removing and trying again... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
Workaround for #2904, broken build for Intel compilers