-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some build warnings caused by unused variables/unnecessary tests #3056
Conversation
@@ -40,7 +40,6 @@ void test_when_each_from_list() | |||
|
|||
unsigned id = fut.get(); | |||
|
|||
HPX_TEST(id >= 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should rather be HPX_TEST(id > 0)
, shouldn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the test correctly, no. At least id
will be 0 the for the first future processed by when_each
a bit further down. The important test is HPX_TEST_EQ(id, idx)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, I see now. Good.
@@ -52,7 +51,6 @@ void test_when_each_from_list() | |||
unsigned id = fut.get(); | |||
|
|||
HPX_TEST_EQ(idx, id); | |||
HPX_TEST(id >= 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
@@ -101,7 +99,6 @@ void test_when_each_from_list_iterators() | |||
|
|||
unsigned id = fut.get(); | |||
|
|||
HPX_TEST(id >= 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And many more to come...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@@ -40,7 +40,6 @@ void test_when_each_from_list() | |||
|
|||
unsigned id = fut.get(); | |||
|
|||
HPX_TEST(id >= 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh, I see now. Good.
No description provided.