-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli resample sensor #360
Cli resample sensor #360
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
…accordingly Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
We now know how to test CLI tasks, so I wonder if we can add a small test. Is there some sample series in some conftest we can resample?
Also: This resamples all data of the sensor. Which is fine. But I have a question about this in practice: I can imagine that new data with a different resolution already started coming in.
- Will our APIs catch that problem at the moment?
- Will this task still be able to resample in the case that data with a different resolution made it in?
# Conflicts: # documentation/changelog.rst
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
This reverts commit bd8f1fa.
Signed-off-by: F.N. Claessen <felix@seita.nl>
Great suggestion! The CLI command now let's you pass a time window. |
This PR adds a CLI command to resample sensor data to a different resolution.
Requires SeitaBV/timely-beliefs#99.