-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI function for adding assets, weather sensors & add dummy market #74
Merged
nhoening
merged 16 commits into
main
from
issue-57-CLI_function_for_adding_assets_and_weather_sensors
Apr 1, 2021
Merged
CLI function for adding assets, weather sensors & add dummy market #74
nhoening
merged 16 commits into
main
from
issue-57-CLI_function_for_adding_assets_and_weather_sensors
Apr 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich its validations
…ify forecasting generation code
nhoening
changed the title
CLI function for adding assets and weather sensors
CLI function for adding assets, weather sensors & add dummy market
Mar 30, 2021
Flix6x
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main comments:
- Possible new issue about what data to delete when deleting users
- Clear up what "structure" means
nhoening
deleted the
issue-57-CLI_function_for_adding_assets_and_weather_sensors
branch
April 1, 2021 15:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #57