Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ->terminate and ->finalize methods to the formatter #723

Merged
merged 2 commits into from Sep 25, 2016
Merged

Add ->terminate and ->finalize methods to the formatter #723

merged 2 commits into from Sep 25, 2016

Conversation

autarch
Copy link
Contributor

@autarch autarch commented Sep 22, 2016

No description provided.

@autarch
Make tests passw with Test2::Harness preloading enabled
d61c4ad
@autarch
Add ->terminate and ->finalize methods to the Formatter
8117cb4 
By default, these do nothing, but they're necessary to implement any sort of
document-oriented format. Otherwise there's no chance for the formatter to
"close" the output. For example, if you're generating XML you need a chance to
close all open tags.
@exodist exodist merged commit 8117cb4 into master Sep 25, 2016
exodist added a commit that referenced this pull request Sep 25, 2016
@exodist
v1.302060
2150687 
    - Formatters now have terminate() and finalize() methods. These are called
      when there is a skip_all or bail event (terminate) or when a test suite
      is exiting normally (finalize). This allows formatters to finalize their
      output, which is important for any sort of document-oriented format (as
      opposed to a stream format like TAP). (#723)
@exodist exodist deleted the autarch/formatter-cleanup branch November 8, 2016 15:56
@exodist exodist restored the autarch/formatter-cleanup branch November 8, 2016 15:56
@exodist exodist deleted the autarch/formatter-cleanup branch November 8, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@autarch @exodist