Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incomingBidInSellerCurrency to reporting browserSignals spec for seller #1090

Open
laurb9 opened this issue Mar 19, 2024 · 1 comment
Open

Comments

@laurb9
Copy link

laurb9 commented Mar 19, 2024

As a component seller, we need to determine the amount our scoreAd() subtracted from the bid, from event-level report data emitted by reportResult(), in a consistent currency.

When both buyer and seller agree to operate in the same currency, bid and modifiedBid in browserSignals cover this need.

When the buyer is not known by seller to bid in the same currency - even if it actually does - or the seller converts it in scoreAd(), browserSignals is no longer sufficient, as bid becomes a unitless value per 5.3 Currencies in Reporting.

We would need the incomingBidInSellerCurrency to be passed in browserSignals, either replacing bid or as a separate field. This value seems to be used only to provide a value for the highestScoringOtherBid macro at this time.

To illustrate the problem, I run a few tests with different values for sellerCurrency, perBuyerCurrencies for buyer and bidCurrency returned by generateBid(), collecting the relevant fields from browserSignals in reportResult(). seller assumes its currency is USD, and scoreAd() performs conversion from MXP at 0.05 rate where applicable.

Screenshot 2024-03-18 at 10 04 45 PM

The middle two rows are most common. sellerCurrency is set, perBuyerCurrencies is not and generateBid() chooses the currency to bid into. The win event has two values, modifiedBid known to be in sellerCurrency and bid in an unknown unit (??? currency) from which it is not possible to derive the value we need.

It would seem that if bid is to have any relationship at all with bidCurrency (defined as "Currency required by auction configuration" which I take to be sellerCurrency in this case) then bid should be the original but converted value.

@laurb9 laurb9 changed the title Add incomingBidInSellerCurrency to reporting browserSignals Reporting when buyer and seller transact in different currencies Mar 19, 2024
@laurb9 laurb9 changed the title Reporting when buyer and seller transact in different currencies Add incomingBidInSellerCurrency to reporting browserSignals spec for seller Mar 25, 2024
@laurb9
Copy link
Author

laurb9 commented Oct 16, 2024

Discussed in WICG on 3/27

Outcome is perBuyerSignals needs to be set and the buyer should be told ahead of time what currency they should use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant