-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sizeGroup error on joinAdInterestGroup #970
Comments
@gtanzer to take a look |
Hi, is there any news on this matter? Thanks |
Sorry, missed this in the new year's shuffle. I think we just missed implementing this part of the explainer, should be easy to fix. Tagging @xiaochen-z |
The current implementation does miss this specified behavior. I will work on a fix. |
After discussing with the Protected Audience team, we have decided to support this functionality in the future. I have a pull request #1008 to update the explainer. |
In the following link, the possibility of specifying the optional fields 'adSizes' and 'sizeGroups' is indicated. In particular:
However, we receive the following error when using named sizes in the interest group:
TypeError: Failed to execute 'joinAdInterestGroup' on 'Navigator': ads[2].sizeGroup 'size3' for AuctionAdInterestGroup with owner 'https://www.example-dsp.com' and name 'womens-running-shoes' The assigned size group does not exist in sizeGroups map.
This example gives error:
This, on the other hand, works correctly (there are only sizeGroup specified):
Can't we just specify named sizes in
sizeGroup
field? Thank you in advanceThe text was updated successfully, but these errors were encountered: