Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Dropdown module not included in custom build #2847

Closed
ZNS opened this issue Oct 17, 2014 · 4 comments
Closed

Dropdown module not included in custom build #2847

ZNS opened this issue Oct 17, 2014 · 4 comments

Comments

@ZNS
Copy link

ZNS commented Oct 17, 2014

The dropdown directive is never included in a custom build when creating it here: http://angular-ui.github.io/bootstrap/ I've tried to only add the dropdown and also adding all modules.

@mvhecke
Copy link
Contributor

mvhecke commented Oct 17, 2014

Could you give us a bit more information @ZNS, because we can't reproduce it now. What steps do you take to create a custom build?

@ZNS
Copy link
Author

ZNS commented Oct 17, 2014

  1. Go to the URL above
  2. Click "Create build" button
  3. Select only "Dropdown" and click "Download 1 modules"
  4. Inside the zip file open up ui-bootstrap-custom-0.10.0.js this is the content of that file:

/*

@pkozlowski-opensource
Copy link
Member

OK, so based on the all the problems we had with the custom build and lack of free cycles to maintain it properly I'm more and more into removing this feature altogether....

@mvhecke
Copy link
Contributor

mvhecke commented Oct 17, 2014

@ZNS I suggest that you use the build function of Grunt as explained here.

@pkozlowski-opensource I tend to agree with you because it's fairly easy to generate a custom build using the task runner and it's hard enough to maintain a project of this size.

chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Nov 14, 2014
- use modules in mappings file
- generate concatenated JS
- generate tpl and non-tpl file with banner
- generate zip file for custom builds
- add browser compatibility message
- speed up page by deferring loading of files
- only load the files when needed. Cache them after they're loaded.

Fixes angular-ui#2960
Fixes angular-ui#2847
Fixes angular-ui#2625
Fixes angular-ui#2489
Fixes angular-ui#2357
Fixes angular-ui#2176
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Nov 14, 2014
Use approach from Twitter Bootstrap. Most of the code is from their customizer.

- use modules in mappings file
- generate concatenated JS
- generate tpl and non-tpl file with banner
- generate zip file for custom builds
- add browser compatibility message
- speed up page by deferring loading of files
- only load the files when needed. Cache them after they're loaded.

Fixes angular-ui#2960
Fixes angular-ui#2847
Fixes angular-ui#2625
Fixes angular-ui#2489
Fixes angular-ui#2357
Fixes angular-ui#2176
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Nov 14, 2014
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Nov 14, 2014
Use approach from Twitter Bootstrap. Most of the code is from their customizer.

- use modules in mappings file
- generate concatenated JS
- generate tpl and non-tpl file with banner
- generate zip file for custom builds
- add browser compatibility message
- speed up page by deferring loading of files
- only load the files when needed. Cache them after they're loaded.

Fixes angular-ui#2960
Fixes angular-ui#2847
Fixes angular-ui#2625
Fixes angular-ui#2489
Fixes angular-ui#2357
Fixes angular-ui#2176
Closes angular-ui#2892
OronNadiv pushed a commit to lanetix/bootstrap that referenced this issue Nov 18, 2014
Use approach from Twitter Bootstrap. Most of the code is from their customizer.

- use modules in mappings file
- generate concatenated JS
- generate tpl and non-tpl file with banner
- generate zip file for custom builds
- add browser compatibility message
- speed up page by deferring loading of files
- only load the files when needed. Cache them after they're loaded.

Fixes angular-ui#2960
Fixes angular-ui#2847
Fixes angular-ui#2625
Fixes angular-ui#2489
Fixes angular-ui#2357
Fixes angular-ui#2176
Closes angular-ui#2892
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants