Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(tooltip): evaluate appendToBody on init #2921

Conversation

chrisirhc
Copy link
Contributor

This wasn't working properly with the location change code
(lines 305-314) because the observe call happens asynchronously after
the linking function has completed.

Hence, the locationChangeSuccess wasn't being set up unless the global
tooltip option's appendToBody option was set to true.

This wasn't working properly with the location change code
(lines 305-314) because the observe call happens asynchronously after
the linking function has completed.

Hence, the locationChangeSuccess wasn't being set up unless the global
tooltip option's appendToBody option was set to true.
@chrisirhc chrisirhc added this to the 0.12 milestone Nov 2, 2014
@chrisirhc chrisirhc closed this in e10d561 Nov 5, 2014
@chrisirhc chrisirhc deleted the feature/tooltip-remove-append-observer branch November 5, 2014 09:22
OronNadiv pushed a commit to lanetix/bootstrap that referenced this pull request Nov 18, 2014
This wasn't working properly with the location change code
(lines 305-314) because the observe call happens asynchronously after
the linking function has completed.

Hence, the locationChangeSuccess wasn't being set up unless the global
tooltip option's appendToBody option was set to true.

Closes angular-ui#2921
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant