Skip to content

Commit

Permalink
fix(core): fix #4592. this in link functions = window, not the direct…
Browse files Browse the repository at this point in the history
…ive.

I could not find where self.shown was used anywhere so just removed it
  • Loading branch information
swalters committed Jan 12, 2016
1 parent 9a736c9 commit cad146b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/js/core/directives/ui-grid-column-menu.js
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,6 @@ function ($timeout, gridUtil, uiGridConstants, uiGridColumnMenuService, $documen
templateUrl: 'ui-grid/uiGridColumnMenu',
replace: true,
link: function ($scope, $elm, $attrs, uiGridCtrl) {
var self = this;

uiGridColumnMenuService.initialize( $scope, uiGridCtrl );

$scope.defaultMenuItems = uiGridColumnMenuService.getDefaultMenuItems( $scope );
Expand Down Expand Up @@ -375,7 +373,7 @@ function ($timeout, gridUtil, uiGridConstants, uiGridColumnMenuService, $documen

$scope.$broadcast('hide-menu', { originalEvent: event });
} else {
self.shown = $scope.menuShown = true;
$scope.menuShown = true;
uiGridColumnMenuService.repositionMenu( $scope, column, colElementPosition, $elm, $columnElement );

$scope.colElement = $columnElement;
Expand Down

0 comments on commit cad146b

Please sign in to comment.