Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort number does not start from 0 when there is default sorted column ui-grid 3.0 #4685

Closed
zhenyi2697 opened this issue Nov 12, 2015 · 0 comments
Closed

Sort number does not start from 0 when there is default sorted column ui-grid 3.0 #4685

zhenyi2697 opened this issue Nov 12, 2015 · 0 comments
Labels
Low-Pri Bug type: bug

Comments

@zhenyi2697
Copy link

When sorting is enabled by default for a column, the sorting number is 0. -> OK
But when I clicked another column, the sorting number changes to 1 while there is only one sorted column. -> It should be 0.

See this plunker:
http://plnkr.co/edit/q0Dhe9MLzgteYqdjtq6r?p=preview
JLLeitschuh added a commit to JLLeitschuh/ui-grid that referenced this issue Dec 3, 2015
@JLLeitschuh
fix(core): Sort Priority Zero Based
6fe0528 
Before sort priority was a mix of 0 and 1 based.
You could create columns with a sort priority of zero but once the user
clicked on a column to sort it its index would change to 1. There was no
way for the sort index to return to 0 from within the grid's menus.
This mix of 0 and 1 based sorting was confusing and created UI problems
when displaying the sort index in the column header.

Closes angular-ui#4685
BREAKING CHANGE:
**GridOptions.columnDef.sort.priority** now expects the lowest value
to be 0.
The Grid Header will display a sort priority of 0 as 1.
Using `if(col.sort.priority)` to determine if a column is sorted is no
longer valid as `0 == false`.
Saved grid objects may be affected by this.
@JLLeitschuh JLLeitschuh mentioned this issue Dec 3, 2015
Merged
JLLeitschuh added a commit to JLLeitschuh/ui-grid that referenced this issue Dec 3, 2015
@JLLeitschuh
fix(core): Sort Priority Zero Based
cca7734 
Before sort priority was a mix of 0 and 1 based.
You could create columns with a sort priority of zero but once the user
clicked on a column to sort it its index would change to 1. There was no
way for the sort index to return to 0 from within the grid's menus.
This mix of 0 and 1 based sorting was confusing and created UI problems
when displaying the sort index in the column header.

Closes angular-ui#4685
BREAKING CHANGE:
**GridOptions.columnDef.sort.priority** now expects the lowest value
to be 0.
The Grid Header will display a sort priority of 0 as 1.
Using `if(col.sort.priority)` to determine if a column is sorted is no
longer valid as `0 == false`.
Saved grid objects may be affected by this.
JLLeitschuh added a commit to JLLeitschuh/ui-grid that referenced this issue Jan 22, 2016
@JLLeitschuh
fix(core): Sort Priority Zero Based
6d41f3d 
Before sort priority was a mix of 0 and 1 based.
You could create columns with a sort priority of zero but once the user
clicked on a column to sort it its index would change to 1. There was no
way for the sort index to return to 0 from within the grid's menus.
This mix of 0 and 1 based sorting was confusing and created UI problems
when displaying the sort index in the column header.

Closes angular-ui#4685
BREAKING CHANGE:
**GridOptions.columnDef.sort.priority** now expects the lowest value
to be 0.
The Grid Header will display a sort priority of 0 as 1.
Using `if(col.sort.priority)` to determine if a column is sorted is no
longer valid as `0 == false`.
Saved grid objects may be affected by this.
JLLeitschuh added a commit to JLLeitschuh/ui-grid that referenced this issue Jan 22, 2016
@JLLeitschuh
fix(core): Sort Priority Zero Based
62dbcfe 
Before sort priority was a mix of 0 and 1 based.
You could create columns with a sort priority of zero but once the user
clicked on a column to sort it its index would change to 1. There was no
way for the sort index to return to 0 from within the grid's menus.
This mix of 0 and 1 based sorting was confusing and created UI problems
when displaying the sort index in the column header.

Closes angular-ui#4685
BREAKING CHANGE:
**GridOptions.columnDef.sort.priority** now expects the lowest value
to be 0.
The Grid Header will display a sort priority of 0 as 1.
Using `if(col.sort.priority)` to determine if a column is sorted is no
longer valid as `0 == false`.
Saved grid objects may be affected by this.
ShayArtzi pushed a commit to ShayArtzi/ui-grid that referenced this issue Jan 22, 2016
@JLLeitschuh @ShayArtzi
fix(core): Sort Priority Zero Based
13902cb 
Before sort priority was a mix of 0 and 1 based.
You could create columns with a sort priority of zero but once the user
clicked on a column to sort it its index would change to 1. There was no
way for the sort index to return to 0 from within the grid's menus.
This mix of 0 and 1 based sorting was confusing and created UI problems
when displaying the sort index in the column header.

Closes angular-ui#4685
BREAKING CHANGE:
**GridOptions.columnDef.sort.priority** now expects the lowest value
to be 0.
The Grid Header will display a sort priority of 0 as 1.
Using `if(col.sort.priority)` to determine if a column is sorted is no
longer valid as `0 == false`.
Saved grid objects may be affected by this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low-Pri Bug type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zhenyi2697 @imbalind