Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Continues searching if a non-symbol matches a symbol link (#901) #909

Conversation

d-ronnqvist
Copy link
Contributor

  • Explanation:
    This fixes an issue where a heading with the same name as a symbol could cause symbol link to not find the heading. This issue is solved by moving the check that the found page is a symbol deeper into the implementation so that DocC can skip non-symbol pages and continue searching for symbol matches.
    Note: The diff is significantly smaller than it looks. It's basically 6 lines that moved from one place to another but because the inner implementation is indented one level deeper than before, it look like ~100 lines changed.
  • Scope: Confusing warning for some symbol links that should resolve without warnings.
  • Issue: rdar://126580675
  • Risk: Low.
  • Testing:
  • Reviewer: @mayaepps @patshaughnessy
  • Original PR: Continues searching if a non-symbol matches a symbol link #901

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 6b83d37 into swiftlang:release/6.0 May 7, 2024
2 checks passed
@d-ronnqvist d-ronnqvist deleted the non-symbol-match-to-symbol-link-6.0 branch May 7, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants