Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vend modulesPath as API to SourceKit-LSP #7200

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

neonichu
Copy link
Contributor

No description provided.

@neonichu neonichu self-assigned this Dec 13, 2023
@neonichu
Copy link
Contributor Author

swiftlang/sourcekit-lsp#998
@swift-ci please test

@@ -526,7 +526,7 @@ public class BuildPlan: SPMBuildCore.BuildPlan {
for target in targets {
switch target {
case .swift(let targetDescription):
arguments += ["-I", targetDescription.moduleOutputPath.parentDirectory.pathString]
arguments += ["-I", targetDescription.modulesPath.pathString]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These paths aren't the same I assume? If so, shouldn't this change have some impact on the test suite, either requiring to update tests or add a new one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're the same in the majority of cases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'm worried about the fact that the remaining minority of cases doesn't seem to be covered with tests, otherwise this change would've broken such tests?

@MaxDesiatov MaxDesiatov added the needs tests This change needs test coverage label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs tests This change needs test coverage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants