Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in Contributing.md #2005

Merged

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 5, 2023

Fixing two issues:

Thanks @natikgadzhi for noting this.

Fixing two issues:
- `SyntaxSupport` should use the `[][]` style link because the link is defined at the bottom of the page.
- We need to move the `@Comment` to the end of the page to avoid hitting swiftlang/swift-docc#685 (comment)
@ahoppen ahoppen requested a review from bnbarham August 5, 2023 04:10
@ahoppen
Copy link
Member Author

ahoppen commented Aug 5, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented Aug 7, 2023

@swift-ci Please test

@ahoppen ahoppen force-pushed the ahoppen/broken-links-in-contributing-page branch from f659181 to 90e4b36 Compare August 7, 2023 03:16
@ahoppen
Copy link
Member Author

ahoppen commented Aug 7, 2023

@swift-ci Please test Windows

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented Aug 7, 2023

@swift-ci Please test Windows

@ahoppen ahoppen merged commit e42bece into swiftlang:main Aug 7, 2023
@ahoppen ahoppen deleted the ahoppen/broken-links-in-contributing-page branch August 7, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants