Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Identifier wrapper that strips backticks from token text #2576

Merged

Commits on Mar 29, 2024

  1. Remove backticks when creating Identifier

    Added a new Identifier type which contains a name property
    
    This name property contains a sanitized version of the TokenSyntax's
    text property which for now only consists of trimming backticks
    adammcarter committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    23e48f1 View commit details
    Browse the repository at this point in the history
  2. Added TokenSyntax identifier property

    This acts as a convenience property to convert a TokenSyntax to an
    Identifier
    adammcarter committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    d5e150e View commit details
    Browse the repository at this point in the history
  3. Conform Identifier to Sendable and Hashable

    This isn't explicitly needed for this problem but it seems as though
    the default for all types that can conform to Sendable/Hashable should
    
    This also sets up this new type for Swift 6.0 (and the current Swift 5.10)
    to pass this type around safely when needed
    
    As well as allows Identifier to be a key in a dictionary which could be
    a common scenario
    adammcarter committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    336b4b3 View commit details
    Browse the repository at this point in the history
  4. Make Identifier initializer failable

    When trying to create an Identifier from a non-identifier token, the
    initializer should fail, returning nil
    
    Additionally the identifier property of the TokenSyntax should also return nil
    adammcarter committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    a63ade8 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2024

  1. WIP - SyntaxText

    adammcarter committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    21ba4fb View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Run formatter

    plemarquand committed May 27, 2024
    Configuration menu
    Copy the full SHA
    1b4a841 View commit details
    Browse the repository at this point in the history
  2. Address review comments

    plemarquand committed May 27, 2024
    Configuration menu
    Copy the full SHA
    85714ab View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    d07cffd View commit details
    Browse the repository at this point in the history
  2. Address comments

    plemarquand committed May 30, 2024
    Configuration menu
    Copy the full SHA
    3a8c221 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    1e39d2d View commit details
    Browse the repository at this point in the history
  2. Update release notes

    plemarquand committed May 31, 2024
    Configuration menu
    Copy the full SHA
    e903d9a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de2d770 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2ce026f View commit details
    Browse the repository at this point in the history
  5. Move release notes to 601

    plemarquand committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8cc8dd3 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2024

  1. Configuration menu
    Copy the full SHA
    53234d8 View commit details
    Browse the repository at this point in the history