-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Identifier wrapper that strips backticks from token text #2576
Merged
plemarquand
merged 15 commits into
swiftlang:main
from
adammcarter:adamcarter93/separate-backtick-tokens
Jun 3, 2024
Merged
Add Identifier wrapper that strips backticks from token text #2576
plemarquand
merged 15 commits into
swiftlang:main
from
adammcarter:adamcarter93/separate-backtick-tokens
Jun 3, 2024
Commits on Mar 29, 2024
-
Remove backticks when creating Identifier
Added a new Identifier type which contains a name property This name property contains a sanitized version of the TokenSyntax's text property which for now only consists of trimming backticks
Configuration menu - View commit details
-
Copy full SHA for 23e48f1 - Browse repository at this point
Copy the full SHA 23e48f1View commit details -
Added TokenSyntax identifier property
This acts as a convenience property to convert a TokenSyntax to an Identifier
Configuration menu - View commit details
-
Copy full SHA for d5e150e - Browse repository at this point
Copy the full SHA d5e150eView commit details -
Conform Identifier to Sendable and Hashable
This isn't explicitly needed for this problem but it seems as though the default for all types that can conform to Sendable/Hashable should This also sets up this new type for Swift 6.0 (and the current Swift 5.10) to pass this type around safely when needed As well as allows Identifier to be a key in a dictionary which could be a common scenario
Configuration menu - View commit details
-
Copy full SHA for 336b4b3 - Browse repository at this point
Copy the full SHA 336b4b3View commit details -
Make Identifier initializer failable
When trying to create an Identifier from a non-identifier token, the initializer should fail, returning nil Additionally the identifier property of the TokenSyntax should also return nil
Configuration menu - View commit details
-
Copy full SHA for a63ade8 - Browse repository at this point
Copy the full SHA a63ade8View commit details
Commits on Apr 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 21ba4fb - Browse repository at this point
Copy the full SHA 21ba4fbView commit details
Commits on May 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1b4a841 - Browse repository at this point
Copy the full SHA 1b4a841View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85714ab - Browse repository at this point
Copy the full SHA 85714abView commit details
Commits on May 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d07cffd - Browse repository at this point
Copy the full SHA d07cffdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a8c221 - Browse repository at this point
Copy the full SHA 3a8c221View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1e39d2d - Browse repository at this point
Copy the full SHA 1e39d2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e903d9a - Browse repository at this point
Copy the full SHA e903d9aView commit details -
Configuration menu - View commit details
-
Copy full SHA for de2d770 - Browse repository at this point
Copy the full SHA de2d770View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ce026f - Browse repository at this point
Copy the full SHA 2ce026fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8cc8dd3 - Browse repository at this point
Copy the full SHA 8cc8dd3View commit details
Commits on Jun 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 53234d8 - Browse repository at this point
Copy the full SHA 53234d8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.