aurelia-binding.d.ts beta.1.0.1 issues with TypeScript noImplicitAny=true

[nil4]

The file aurelia-binding.d.ts at version 1.0.0-beta.1.0.1 contains the following definitions that cause errors when the noImplicitAny TypeScript option is enabled (note the initialize and register functions have no parameter signatures):

  export class ValueConverterResource {
    static convention(name: string): ValueConverterResource;
    constructor(name: string);
    initialize(container, target): void;
    register(registry, name): void;
  }
 export class BindingBehaviorResource {
    static convention(name: string): BindingBehaviorResource;
    constructor(name: string);
    initialize(container, target): void;
    register(registry, name): void;
  }

[EisenbergEffect]

This sounds like an awesome opportunity to submit a pull request :)

[nil4]

Apologies, I am new at this GitHub thing; I wanted to create a pull request against this repository but I seem to have done something completely different. Let me try again.

[nil4]

@EisenbergEffect: pull request #234 created.

[mikeobrien]

I'm hitting another issue with 1.0.0-beta.1.0.1:

aurelia-binding@1.0.0-beta.1.0.1/aurelia-binding.d.ts(58,16): error TS7006: Parameter 'container' implicitly has an 'any' type.

So how are these .d.ts files being maintained? I was under the impression they were being generated by Babel so not something we could just fix directly in the .d.ts file and submit a PR for.

Also, another thought, what would you think about adding a compile step to your build to compile the .d.ts files? I regularly run into problems with these files when I upgrade that could have been caught with a compile step.

I'm not sure how this is being handled, so maybe missing something.

[EisenbergEffect]

The binding library doesn't use code generation for it's d.ts anymore, so you can just submit a PR against the d.ts file to fix issues.

[mikeobrien]

Thx, good to know. Is this true for all Aurelia libs or just some like binding?

[EisenbergEffect]

Only for binding at the moment. The rest have their d.ts files generated from source.

[EisenbergEffect]

We may look at converting all libraries to have custom d.ts similar to this repo in the future.

[mikeobrien]

Great, thx for the info!