Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check whether the Area overrides the collection permission #1789

Merged
merged 1 commit into from
Jan 15, 2015
Merged

Double check whether the Area overrides the collection permission #1789

merged 1 commit into from
Jan 15, 2015

Conversation

hissy
Copy link
Contributor

@hissy hissy commented Jan 10, 2015

If an Area overrides the master collection permissions, the instances of the Area should overrides each collections.

@katzueno
Copy link
Contributor

He wants to check if this is right way to do.

Currently, the page permission somehow ignore Area's Page Type default permission, or manual permission setting but master collection permission.

We had this bug in a site where

  • the top page doesn't have the "Sidebar" area
  • Child page has "Sidebar" area
  • We want to have Page Default permission or manual permission for a certain group and editor won't be able to touch the Sidebar area but Main area.
  • But it doesn't work. Noe being able to set the area permission right way. (In this case, the user was able to modify Layout and Design even the setting said it's not supposed to.

Thanks

@aembler
Copy link
Member

aembler commented Jan 14, 2015

Yes, that makes sense. I think this type of check is being done at the Area level – but it doesn't look like it's being done when you're at the block level, and going back up the permissions chain. Does that sound right? This is pretty low level but I think you're right here. Does this code seem to fix the issue for you?

@hissy
Copy link
Contributor Author

hissy commented Jan 14, 2015

1
2
3
4
5
6

@aembler
Copy link
Member

aembler commented Jan 15, 2015

Very helpful, thank you.

aembler added a commit that referenced this pull request Jan 15, 2015
Double check whether the Area overrides the collection permission
@aembler aembler merged commit f8e7df9 into concretecms:develop Jan 15, 2015
@hissy hissy deleted the hotfix/permission/BlockAssignment branch January 16, 2015 01:07
hissy added a commit to hissy/concrete5-legacy that referenced this pull request Jan 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants