-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oss-fuzz integration is split across (at least) 3 repositories and is fragile #10226
Comments
The |
The use of |
Also note that this checkout of the containerd repo does not use any information about the branch or PR in flight, although I think the "run fuzzers" does try and handle something PR related? (the default mode for the "run fuzzers" action is "code change" testing). However, I can't find the actual checking out the PR branch, but it could be hidden in the python code that gets kicked off after this checkout of What this definitely means is that the |
Hi there, I understand your integration with oss-fuzz. I feel it is better to maintain the entire build process in the build.sh because we're anyway cloning our entire repo in the Dockerfile and also incase of any issue, it would direct all the pull requests to oss-fuzz. It is easy to maintain. Yes, I agree it is better to maintain a specific state of instrumentation, not doing so might effect the fuzz test results. Yes, CI action for build fuzzers is always taking the latest commit on the default branch. I verified it from the build job logs. But according to this line, the run fuzzers uses a default mode which should fetch the changes from pull request in theory. I can verify this by explicitly adding a crash scenario on my PR. |
oss-fuzz provides fuzzing for open source software such as containerd. Our integration with it is split in (at least) 3 repositories:
contrib/fuzz
directory and a workflow in our main repository.projects/containerd
directory in the main oss-fuzz repository.github.com/AdamKorcz/instrumentation
.This can make it challenging to find issues, and resolving them can take many separate pull requests.
Let's use this issue as a discussion forum for improvements.
The text was updated successfully, but these errors were encountered: