Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change point_stat log message from "obs type" to "obs var name". #1514

Closed
20 tasks done
JohnHalleyGotway opened this issue Oct 9, 2020 · 0 comments · Fixed by #1515
Closed
20 tasks done

Change point_stat log message from "obs type" to "obs var name". #1514

JohnHalleyGotway opened this issue Oct 9, 2020 · 0 comments · Fixed by #1515
Assignees
Labels
priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NCAR National Center for Atmospheric Research type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Oct 9, 2020

Describe the Enhancement

This is a very minor, quick, and easy change, as described in this RT ticket:
https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=97010

The following DEBUG3 log message from Point-Stat isn't very clear:
DEBUG 2: Processing TMP/P900-750 versus TMP/P900-750, for observation type ADPUPA, over region DTC165, for interpolation method NEAREST(1), using 132 matched pairs.
DEBUG 3: Number of matched pairs = 132
DEBUG 3: Observations processed = 89893
DEBUG 3: Rejected: station id = 0
DEBUG 3: Rejected: obs type = 79788
DEBUG 3: Rejected: valid time = 0
DEBUG 3: Rejected: bad obs value = 0
DEBUG 3: Rejected: off the grid = 5
DEBUG 3: Rejected: topography = 0
DEBUG 3: Rejected: level mismatch = 9219
DEBUG 3: Rejected: quality marker = 0
DEBUG 3: Rejected: message type = 344
DEBUG 3: Rejected: masking region = 405
DEBUG 3: Rejected: bad fcst value = 0
DEBUG 3: Rejected: bad climo mean = 0
DEBUG 3: Rejected: bad climo stdev = 0
DEBUG 3: Rejected: duplicates = 0

Replace "obs type" with "obs var name".

Time Estimate

1 hour.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues.

Relevant Deadlines

None

Funding Source

None

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: none required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: application code priority: medium Medium Priority requestor: NCAR National Center for Atmospheric Research labels Oct 9, 2020
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.0 milestone Oct 9, 2020
@JohnHalleyGotway JohnHalleyGotway self-assigned this Oct 9, 2020
JohnHalleyGotway added a commit that referenced this issue Oct 9, 2020
…me'. Also, to avoid future confusion, rename variable 'rej_gc' with 'rej_var'.
@JohnHalleyGotway JohnHalleyGotway linked a pull request Oct 9, 2020 that will close this issue
@TaraJensen TaraJensen added the reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Medium Priority reporting: DTC NOAA BASE NOAA Office of Atmospheric Research DTC Project requestor: NCAR National Center for Atmospheric Research type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants