Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat the magic_str() for NetCDF data files. #1655

Closed
20 tasks done
JohnHalleyGotway opened this issue Feb 5, 2021 · 0 comments · Fixed by #1656
Closed
20 tasks done

Reformat the magic_str() for NetCDF data files. #1655

JohnHalleyGotway opened this issue Feb 5, 2021 · 0 comments · Fixed by #1656
Assignees
Labels
component: user support User support issue priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Milestone

Comments

@JohnHalleyGotway
Copy link
Collaborator

JohnHalleyGotway commented Feb 5, 2021

Describe the Enhancement

This is a minor change to how the magic_str() should be formatted when processing NetCDF data files. This caused some confusion for a user, as described in this MET-Help ticket:
https://rt.rap.ucar.edu/rt/Ticket/Display.html?id=98524

When processing gridded NetCDF data created by other MET tools, the "level" string in the MET configuration file can be set two different ways.

float APCP_12(lat, lon) ;
	APCP_12:name = "APCP_12" ;
	APCP_12:long_name = "Total precipitation" ;
	APCP_12:level = "A12" ;
	APCP_12:units = "kg/m^2" ;

(1) Define how to index into the NetCDF variable dimensions:

level="(*,*)";

Which results in this type of log message:

DEBUG 2: Processing APCP_12(*,*) versus APCP_12(*,*), for smoothing method NEAREST(1), over region DTC165, using 2651 matched pairs.

(2) Or define the value for the "level" attribute of the NetCDF variable being read:

level="A12";

Which results in this type of log message:

DEBUG 2: Processing APCP_12A12 versus APCP_12A12, for smoothing method NEAREST(1), over region DTC165, using 2651 matched pairs.

The log message from (2) caused confusion. This task is to change the formatting of that string to be "APCP_12/A12" instead.

Instead of just always inserting '/' between the name and level, recommend only doing so if the first character of the level string is NOT '('. Recommend making this change for all vx_data2d libraries that process gridded NetCDF data.

Time Estimate

2 hours. But this might cause some diffs to the NB output which may take a while to check.

Sub-Issues

Consider breaking the enhancement down into sub-issues.
No sub-issues required

Relevant Deadlines

None

Funding Source

?

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: John HG
  • Select scientist(s) or no scientist required: none required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
  • Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s), Project(s), Milestone, and Linked issues
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@JohnHalleyGotway JohnHalleyGotway added type: enhancement Improve something that it is currently doing component: user support User support issue requestor: NOAA/EMC NOAA Environmental Modeling Center priority: medium Medium Priority alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Feb 5, 2021
@JohnHalleyGotway JohnHalleyGotway added this to the MET 10.0.0 milestone Feb 5, 2021
@JohnHalleyGotway JohnHalleyGotway self-assigned this Feb 5, 2021
@JohnHalleyGotway JohnHalleyGotway linked a pull request Feb 5, 2021 that will close this issue
10 tasks
@TaraJensen TaraJensen added reporting: DTC NOAA R2O NOAA Research to Operations DTC Project and removed alert: NEED ACCOUNT KEY Need to assign an account key to this issue labels Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: user support User support issue priority: medium Medium Priority reporting: DTC NOAA R2O NOAA Research to Operations DTC Project requestor: NOAA/EMC NOAA Environmental Modeling Center type: enhancement Improve something that it is currently doing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants