Move GatewayShardsState logic into IndexShard #10093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1monw
force-pushed
the
merge_shard_state
branch
from
6f92c1b
to
7df10f0
Compare
s1monw
force-pushed
the
merge_shard_state
branch
2 times, most recently
from
0c0bfe1
to
6055b1c
Compare
| if (shardStateInfo != null) { | ||
| logger.debug("{} shard state info found: [{}]", request.shardId, shardStateInfo); | ||
| return new NodeGatewayStartedShards(clusterService.localNode(), shardStateInfo.version); | ||
| logger.warn("{} loading local shard state info", request.shardId); |
There was a problem hiding this comment.
this needs to go back to trace?
|
I like this change. Makes it simpler and doesn't require a global map. Left a couple of comments |
|
pushed a new commit |
|
replied to the replies ... |
|
pushed more feedback @bleskes thx |
|
LGTM. left one minor typo comment. @s1monw thx. |
The index shard should take care of shard state persistence since it has all the information and the gateway concept has been removed in master.
s1monw
force-pushed
the
merge_shard_state
branch
from
afd4110
to
a6897aa
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The index shard should take care of shard state persistence since it has
all the information and the gateway concept has been removed in master.