Upgrade to lucene-5.1.0-snapshot-1671894. #10468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a fix for LUCENE-6406.
|
+1 |
jpountz
added a commit
that referenced
this pull request
Apr 7, 2015
Upgrade to lucene-5.1.0-snapshot-1671894.
dadoonet
added a commit
to elastic/elasticsearch-parent
that referenced
this pull request
Apr 9, 2015
|
Also pushed in parent project: elastic/elasticsearch-parent@998793f |
clintongormley
added
:Core/Infra/Core
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Feb 6, 2024
The newly introduced QueryPhaseTimeoutException extends from QueryPhaseExecutionException. It can instead subclass directly SearchException. That allows us to enforce that QueryPhaseExecutionException always has a root cause provided, which helps us enforce that its status code never defaults to 500. These are no serialization changes involved in this change, as QueryPhaseExecutionException exposes the exact same instance members as SearchException, which get serialized over the wire. This change does rename the transport version contant introduced in elastic#10468, but that is safe as the version id is left untouched. It is a cosmetic change to ensure consistency between the constant name and the now renamed exception.
javanna
added a commit
that referenced
this pull request
Feb 6, 2024
The newly introduced QueryPhaseTimeoutException extends from QueryPhaseExecutionException. It can instead subclass directly SearchException. That allows us to enforce that QueryPhaseExecutionException always has a root cause provided, which helps us enforce that its status code never defaults to 500. These are no serialization changes involved in this change, as QueryPhaseExecutionException exposes the exact same instance members as SearchException, which get serialized over the wire. This change does rename the transport version contant introduced in #10468, but that is safe as the version id is left untouched. It is a cosmetic change to ensure consistency between the constant name and the now renamed exception.
felixbarny
pushed a commit
to felixbarny/elasticsearch
that referenced
this pull request
Feb 8, 2024
…105182) The newly introduced QueryPhaseTimeoutException extends from QueryPhaseExecutionException. It can instead subclass directly SearchException. That allows us to enforce that QueryPhaseExecutionException always has a root cause provided, which helps us enforce that its status code never defaults to 500. These are no serialization changes involved in this change, as QueryPhaseExecutionException exposes the exact same instance members as SearchException, which get serialized over the wire. This change does rename the transport version contant introduced in elastic#10468, but that is safe as the version id is left untouched. It is a cosmetic change to ensure consistency between the constant name and the now renamed exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a fix for LUCENE-6406.