Acquire index writer lock before renaming translog file #11396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in 1.x we still rename the translog file before recovery. Yet, essentially the translog is guarded by the IW lock but we perform these operations before we start the engine. This can cause trouble in the shared FS case where we do full restarts and the lock owning node has already dropped off the cluster (another taking over the primary) but has not yet flushed it's translog. If we wait for the IW lock we guarantee that the translog has been flushed. This fixes CI failures like http://build-us-00.elastic.co/job/es_g1gc_1x_metal/9894/
|
LGTM |
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in 1.x we still rename the translog file before recovery. Yet,
essentially the translog is guarded by the IW lock but we perform
these operations before we start the engine. This can cause trouble
in the shared FS case where we do full restarts and the lock owning
node has already dropped off the cluster (another taking over the primary)
but has not yet flushed it's translog. If we wait for the IW lock we guarantee
that the translog has been flushed.
This fixes CI failures like http://build-us-00.elastic.co/job/es_g1gc_1x_metal/9894/