Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synced flush not taking very well #12134

Closed
nik9000 opened this issue Jul 8, 2015 · 4 comments
Closed

Synced flush not taking very well #12134

nik9000 opened this issue Jul 8, 2015 · 4 comments
Assignees
@s1monw

Comments

@nik9000
Copy link
Member

nik9000 commented Jul 8, 2015

I think we're talking about a bug here: https://discuss.elastic.co/t/synced-flush-causes-node-to-restart/24220

It could be that we're both just having trouble but it seems like for some shards synced flush just claims that there are pending operations all the time. Its like reference counting is off or something. I've turned up the logging to 11 and I'll let the system run overnight and then try another synced flush again and hopefully will have something more concrete.

In the mean time it'd be nice to be able to get more insight into the IndexWriter for a shard specifically which condition is causing it to say it has pending operations.
@s1monw
Copy link
Contributor

s1monw commented Jul 9, 2015

I replied to the discuss list... I think it's a bug on 1.x though... master should be ok here

s1monw added a commit to s1monw/elasticsearch that referenced this issue Jul 9, 2015
@s1monw
Use IndexWriter.hasPendingChanges() to detect if a flush is needed.
8aa34ea 
This is required to ensure we flush the indexwriter / commit all changes
even if no docs are indexed. This is important if a merge happend after
the last flush and no further docs have been added. Otherwise merges
will not be committed if no docs where added/updated/deleted.

This is equivalent to what master does today.

Closes elastic#12134
@s1monw s1monw mentioned this issue Jul 9, 2015
Merged
@s1monw s1monw self-assigned this Jul 9, 2015
@mikemccand
Copy link
Contributor

LGTM

s1monw added a commit that referenced this issue Jul 9, 2015
@s1monw
Use IndexWriter.hasPendingChanges() to detect if a flush is needed.
9605650 
This is required to ensure we flush the indexwriter / commit all changes
even if no docs are indexed. This is important if a merge happend after
the last flush and no further docs have been added. Otherwise merges
will not be committed if no docs where added/updated/deleted.

This is equivalent to what master does today.

Closes #12134
@nik9000
Copy link
Member Author

nik9000 commented Jul 29, 2015

Can we close this now that that pull request is merged?

mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
@s1monw
Use IndexWriter.hasPendingChanges() to detect if a flush is needed.
1ac9cf9 
This is required to ensure we flush the indexwriter / commit all changes
even if no docs are indexed. This is important if a merge happend after
the last flush and no further docs have been added. Otherwise merges
will not be committed if no docs where added/updated/deleted.

This is equivalent to what master does today.

Closes elastic#12134
@clintongormley
Copy link
Contributor

Hmm github seems to not be closing issues properly.. Closed by #12146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@s1monw s1monw

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clintongormley @nik9000 @mikemccand @s1monw