Remove support for address resolving in InetSocketTransportAddress #13020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit removes all support for reverse host name resolving from InetSocketTransportAddress. This class now only returns IP addresses. Closes elastic#13014
| } | ||
|
|
||
| public static final InetSocketTransportAddress PROTO = new InetSocketTransportAddress(); | ||
| public static final InetSocketTransportAddress PROTO = new InetSocketTransportAddress(new InetSocketAddress("127.0.0.1", 0)); |
There was a problem hiding this comment.
What uses this? And why is forbidden APIs not angry about passing in String,int here... i feel like i banned that method. I dont like it as its wired to 127.0.0.1 in non-test code.
|
+1 for this. |
|
pushed a new commit @rmuir |
s1monw
added a commit
that referenced
this pull request
Aug 20, 2015
Remove support for address resolving in InetSocketTransportAddress
s1monw
added a commit
that referenced
this pull request
Aug 20, 2015
Remove support for address resolving in InetSocketTransportAddress
clintongormley
added
the
:Distributed/Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit removes all support for reverse host name resolving from
InetSocketTransportAddress. This class now only returns IP addresses.
Closes #13014