Add favicon #13054
Merged
Add favicon #13054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| void handleFavicon(HttpRequest request, HttpChannel channel) { | ||
| if (request.method() == RestRequest.Method.GET) { | ||
| try { | ||
| try (InputStream stream = getClass().getResourceAsStream("/config/favicon.ico")) { |
There was a problem hiding this comment.
should we keep this in memory for performance reasons?
There was a problem hiding this comment.
i dunno, it only impacts users using the browser. i figure that isnt perf critical, the server doesn't get hammered with those. maybe i'm wrong. file is 1KB.
There was a problem hiding this comment.
I can't come up with any more seriousness :)
|
LGTM I raised one little concern 🎱 |
|
Nice... Looks like you were bored with unicast/multicast things :) |
|
LGTM |
clintongormley
added
>enhancement
:Core/Infra/REST API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this. Let the bikeshedding begin :)