Stop o.e.c.s.Settings from leaking Guava dependency #13517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The public org.elasticsearch.common.settings.Settings#getAsMap method leaks the dependency on Guava by returning a com.google.common.collect.ImmutableMap. The leaking of this dependency should be removed in preparation for the eventual complete removal of Guava as a dependency. Relates #13224
jasontedor
added
>enhancement
review
:Core/Infra/Settings
|
LGTM |
1 similar comment
|
LGTM |
jasontedor
added a commit
that referenced
this pull request
Sep 11, 2015
…ava-dependency Stop o.e.c.s.Settings from leaking Guava dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public
org.elasticsearch.common.settings.Settings#getAsMapmethodleaks the dependency on Guava by returning a
com.google.common.collect.ImmutableMap. The leaking of this dependencyshould be removed in preparation for the eventual complete removal of
Guava as a dependency.
Relates #13224