Prevent losing stacktraces when exceptions occur #13587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
s/loosing/losing/ ? |
s1monw
changed the title
|
LGTM. |
| private static final int VERSION = VERSION_STACK_TRACE; | ||
| private static final String CORRUPTED = "corrupted_"; | ||
| static final String CODEC = "store"; | ||
| static final int VERSION_WRITE_THROWABLE= 2; // we write throwable since 3.0 |
There was a problem hiding this comment.
yeah I wasn't sure yet :)
This commit removes unnecesssary use of ExceptionHelpers where we actually should serialize / deserialize the actual exception. This commit also fixes one of the oddest problems where the actual exception was never rendered / printed if `all shards failed` due to a missing cause. This commit unfortunately doesn't fix Snapshot/Restore which is almost unfixable since it has to serialize XContent and read from it which can't transport exceptions.
s1monw
force-pushed
the
fix_most_exceptions
branch
from
b0e7095
to
bfa984e
Compare
|
I will give this some time before I backport |
lcawl
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes unnecesssary use of ExceptionHelpers where we actually
should serialize / deserialize the actual exception. This commit also
fixes one of the oddest problems where the actual exception was never
rendered / printed if
all shards faileddue to a missing cause.This commit unfortunately doesn't fix Snapshot/Restore which is almost
unfixable since it has to serialize XContent and read from it which can't
transport exceptions.