Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading external plugins to 7.3.0 fails #45073

Closed
spinscale opened this issue Aug 1, 2019 · 6 comments · Fixed by #45107
Closed

Upgrading external plugins to 7.3.0 fails #45073

spinscale opened this issue Aug 1, 2019 · 6 comments · Fixed by #45107
Labels
>bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team

Comments

@spinscale
Copy link
Contributor

Elasticsearch version (bin/elasticsearch --version): 7.3.0

Description of the problem including expected versus actual behavior:

Upgrading to 7.3.0 seems to show some error in build tools.

Steps to reproduce:

After upgrading to gradle 5.5 (or 5.5.1) the following exception occurs:

./gradlew clean check
Starting a Gradle Daemon (subsequent builds will be faster)

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* Where:
Build file '/../cookiecutter-elasticsearch-ingest-processor/ingest-awesome/build.gradle' line: 18

* What went wrong:
A problem occurred evaluating root project 'ingest-awesome'.
> Failed to apply plugin [id 'elasticsearch.esplugin']
   > Could not create task ':integTest'.
      > Could not create task of type 'RestIntegTestTask'.
         > Project with path ':rest-api-spec' could not be found in root project 'ingest-awesome'.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

2: Task failed with an exception.
-----------
* What went wrong:
A problem occurred configuring root project 'ingest-awesome'.
> Failed to notify project evaluation listener.
   > Must specify license and notice file for project :
   > Must specify license and notice file for project :
   > Must specify license and notice file for project :
   > Could not get unknown property 'bundlePlugin' for task set of type org.gradle.api.internal.tasks.DefaultTaskContainer.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
==============================================================================

* Get more help at https://help.gradle.org

BUILD FAILED in 5s

You can use https://github.com/spinscale/elasticsearch-ingest-langdetect as a base and change gradle/wrapper/gradle-wrapper.properties to use gradle 5.5 and then the error manifests.

@jkakavas jkakavas added :Delivery/Build Build or test infrastructure >bug labels Aug 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@alpar-t
Copy link
Contributor

alpar-t commented Aug 1, 2019

Seems to be a regression introduced in #42773 which we haven't caught due to relevant tests being disabled in #42453

@mark-vieira
Copy link
Contributor

@spinscale Sorry for the inconvenience here, we'll get this sorted out in 7.3.1. For now I have a temporary workaround for you:

Add the following to your settings.gradle file:

include ':rest-api-spec'

Add the following to your root build.gradle file:

configurations.all {
  resolutionStrategy.dependencySubstitution {
    substitute project(':rest-api-spec') with module ("org.elasticsearch:rest-api-spec:${elasticsearchVersion}")
  }
}

This should unblock you until the 7.3.1 patch release which includes a permanent fix.

@spinscale
Copy link
Contributor Author

yes that works, thanks for the workaround!

@nelg
Copy link

nelg commented Aug 5, 2019

also impacted by this problem.
https://github.com/nelg/elasticsearch-ingest-csv/tree/maxchars

dnhatn added a commit that referenced this issue Aug 5, 2019
testShouldFlushAfterPeerRecovery was added #28350 to make sure the
flushing loop triggered by afterWriteOperation eventually terminates.
This test relies on the fact that we call afterWriteOperation after
making changes in translog. In #44756, we roll a new generation in
RecoveryTarget#finalizeRecovery but do not call afterWriteOperation.

Relates #28350
Relates #45073
@mark-vieira
Copy link
Contributor

This has been fixed and merged back to the 7.3 branch so it'll be included in the 7.3.1 release.

jrodewig pushed a commit that referenced this issue Aug 6, 2019
testShouldFlushAfterPeerRecovery was added #28350 to make sure the
flushing loop triggered by afterWriteOperation eventually terminates.
This test relies on the fact that we call afterWriteOperation after
making changes in translog. In #44756, we roll a new generation in
RecoveryTarget#finalizeRecovery but do not call afterWriteOperation.

Relates #28350
Relates #45073
dnhatn added a commit that referenced this issue Aug 11, 2019
testShouldFlushAfterPeerRecovery was added #28350 to make sure the
flushing loop triggered by afterWriteOperation eventually terminates.
This test relies on the fact that we call afterWriteOperation after
making changes in translog. In #44756, we roll a new generation in
RecoveryTarget#finalizeRecovery but do not call afterWriteOperation.

Relates #28350
Relates #45073
lukas-vlcek added a commit to vvanholl/elasticsearch-prometheus-exporter that referenced this issue Aug 13, 2019
See elastic/elasticsearch#45073
This fix needs to be removed for ES 7.3.1 and later.
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants