Fix for zero-sized content throwing off toChannelBuffer(). #5543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we start using PagedBytesReference again in BytesStreamOutput? |
|
@jpountz Not sure I understand the question..where else would we use it? |
|
Oops, I had not seen that you already switched back to PagedBytesReference from BytesArray in BytesStreamOutput. All right! +1 to merge this change |
short-circuit writeTo(..) accordingly to avoid unnecessary work. Fixes #5543
hhoffstaette
pushed a commit
that referenced
this pull request
Mar 27, 2014
short-circuit writeTo(..) accordingly to avoid unnecessary work. Fixes #5543
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also short-circuit writeTo(..) accordingly to avoid unnecessary work. This fixes an issue where 0-sized ContentLength replies (e.g. 404) would make some REST tests fail.