Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST API spec for /_search_shards endpoint #5907

Closed
wants to merge 1 commit into from

Conversation

dakrone
Copy link
Member

@dakrone dakrone commented Apr 22, 2014

No description provided.

"local": {
"type": "boolean",
"description": "Return local information, do not retrieve the state from master node (default: false)"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are missing some params here, like: expand_wildcards, ignore_unavailable and allow_no_indices.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I missed those, I will add them.

@javanna
Copy link
Member

javanna commented Apr 23, 2014

I left some comments, it would be nice also to add some REST tests for this.

@javanna javanna self-assigned this Apr 23, 2014
@dakrone
Copy link
Member Author

dakrone commented Apr 23, 2014

@javanna thanks for the comments! I have addressed them and added a REST test for this.

@javanna
Copy link
Member

javanna commented Apr 23, 2014

LGTM

Also adds REST test for /_search_shards

Closes elastic#5907
dakrone added a commit that referenced this pull request Apr 23, 2014
Also adds REST test for /_search_shards

Closes #5907
@dakrone dakrone closed this in 54612ee Apr 23, 2014
dakrone added a commit that referenced this pull request Apr 23, 2014
Also adds REST test for /_search_shards

Closes #5907
dakrone added a commit that referenced this pull request Apr 23, 2014
Also adds REST test for /_search_shards

Closes #5907
mikemccand pushed a commit to mikemccand/elasticsearch that referenced this pull request Apr 24, 2014
Also adds REST test for /_search_shards

Closes elastic#5907
@jpountz jpountz removed the review label Apr 30, 2014
@dakrone dakrone deleted the search-shards-api branch September 9, 2014 13:44
@clintongormley clintongormley added >enhancement :Core/Infra/REST API REST infrastructure and utilities labels Jun 8, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Also adds REST test for /_search_shards

Closes elastic#5907
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
Also adds REST test for /_search_shards

Closes elastic#5907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants