Add REST API spec for /_search_shards endpoint #5907
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "local": { | ||
| "type": "boolean", | ||
| "description": "Return local information, do not retrieve the state from master node (default: false)" | ||
| } |
There was a problem hiding this comment.
I think we are missing some params here, like: expand_wildcards, ignore_unavailable and allow_no_indices.
There was a problem hiding this comment.
Good catch, I missed those, I will add them.
|
I left some comments, it would be nice also to add some REST tests for this. |
|
@javanna thanks for the comments! I have addressed them and added a REST test for this. |
|
LGTM |
Also adds REST test for /_search_shards Closes elastic#5907
dakrone
added a commit
that referenced
this pull request
Apr 23, 2014
Also adds REST test for /_search_shards Closes #5907
dakrone
added a commit
that referenced
this pull request
Apr 23, 2014
Also adds REST test for /_search_shards Closes #5907
dakrone
added a commit
that referenced
this pull request
Apr 23, 2014
Also adds REST test for /_search_shards Closes #5907
mikemccand
pushed a commit
to mikemccand/elasticsearch
that referenced
this pull request
Apr 24, 2014
Also adds REST test for /_search_shards Closes elastic#5907
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
May 19, 2014
clintongormley
added
>enhancement
:Core/Infra/REST API
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Also adds REST test for /_search_shards Closes elastic#5907
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Also adds REST test for /_search_shards Closes elastic#5907
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.