Unify IndicesOptions constants #6068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ | |||
| @Nullable | |||
| private String preference; | |||
| private String[] types = Strings.EMPTY_ARRAY; | |||
| private IndicesOptions indicesOptions = IndicesOptions.lenient(); | |||
| private IndicesOptions indicesOptions = IndicesOptions.ignoreUnavailableExpandOpenOnly(); | |||
…learer what they actually return, reused methods and introduced new one Relates to elastic#6059, where two new constants were introduced in IndicesOptions. There were already two constants there though, one of which we could have reused. This commit tries to unify them.
|
Merged to master and 1.x |
|
This change is marked as breaking in master only for Java API users as it removes two public methods ( |
javanna
added a commit
that referenced
this pull request
May 13, 2014
javanna
added a commit
that referenced
this pull request
May 13, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed IndicesOptions#strict and IndicesOptions#lenient to make it clearer what they actually return, reused methods and introduced new one
Relates to #6059, where two new constants were introduced in IndicesOptions. There were already two constants there though, one of which we could have reused. This commit tries to unify them.