Wait for mapping updates during local recovery #6666
Conversation
when the primary shard is recovering its translog, make sure to wait for new mapping introductions till the mappings have been updated on the master before finalizing the recovery itself also, this change performs the mapping updates in a more optimized manner by batching the types to change into a single set and sending after the translog has been replayed closes elastic#6666
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Can these classes be static?
There was a problem hiding this comment.
they can't at their current placement, because they are in non static inner class. they can be moved to outside, and be made static, but then, at least for the value class, we will need to pass the logger as well. I like it like this, feels more encapsulated, and the perf overhead of non static classes should be insignificant in the context of this operation (mapping updates)
|
Just left a question. Otherwise it looks good to me but I'm not familiar with this code so I might have missed obvious bugs. |
|
LGTM... would be nice to have the option for |
|
@uboness yea, that would be nice, but it would be a bigger change, will push this for now |
|
sure |
when the primary shard is recovering its translog, make sure to wait for new mapping introductions till the mappings have been updated on the master before finalizing the recovery itself also, this change performs the mapping updates in a more optimized manner by batching the types to change into a single set and sending after the translog has been replayed also, remove the wait for mapping on master in the local state tests since this new behavior covers it closes #6666 remove waiting for mapping on master since we do it in recovery
clintongormley
changed the title
clintongormley
added
the
:Search/Mapping
clintongormley
changed the title
when the primary shard is recovering its translog, make sure to wait for new mapping introductions till the mappings have been updated on the master before finalizing the recovery itself
also, this change performs the mapping updates in a more optimized manner by batching the types to change into a single set and sending after the translog has been replayed