Don't attempt to start or fail shard if no master node can be found #6841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,6 +79,7 @@ public void shardFailed(final ShardRouting shardRouting, final String indexUUID, | |||
| DiscoveryNode masterNode = clusterService.state().nodes().masterNode(); | |||
| if (masterNode == null) { | |||
| logger.debug("can't send shard failed for {}. no master known.", shardRouting); | |||
There was a problem hiding this comment.
I think we should change this to a warning level log (without the return it would be logged as warning in the overloaded shardFailed message)
|
LGTM. Left one comment regarding logging levels |
martijnvg
added a commit
that referenced
this pull request
Jul 13, 2014
martijnvg
changed the title
martijnvg
changed the title
martijnvg
changed the title
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Distributed Indexing/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.