MultiGet: Fail when using no routing on an alias to an index that requires routing #7145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
…as to an index that has routing required (for that doc type) Made sure that the routing required check is performed against the concrete index, added use of aliases to existing routing tests. Taken the change to unify the failure message as well to this form: routing is required for [" + index + "]/[" + type + "]/[" + id + "]
|
Sorry @kimchy I updated the PR post LGTM :) found the same bug in multi term vector api and improved tests. Mind having another look? |
|
I see, it was missing concrete index, LGTM |
javanna
added a commit
that referenced
this pull request
Aug 4, 2014
…as to an index that has routing required (for that doc type) Made sure that the routing required check is performed against the concrete index, added use of aliases to existing routing tests. Taken the change to unify the failure message as well to this form: routing is required for [" + index + "]/[" + type + "]/[" + id + "] Closes #7145
javanna
added a commit
that referenced
this pull request
Aug 4, 2014
…as to an index that has routing required (for that doc type) Made sure that the routing required check is performed against the concrete index, added use of aliases to existing routing tests. Taken the change to unify the failure message as well to this form: routing is required for [" + index + "]/[" + type + "]/[" + id + "] Closes #7145
javanna
added a commit
that referenced
this pull request
Sep 8, 2014
…as to an index that has routing required (for that doc type) Made sure that the routing required check is performed against the concrete index, added use of aliases to existing routing tests. Taken the change to unify the failure message as well to this form: routing is required for [" + index + "]/[" + type + "]/[" + id + "] Closes #7145
clintongormley
changed the title
clintongormley
added
the
:Distributed/CRUD
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…as to an index that has routing required (for that doc type) Made sure that the routing required check is performed against the concrete index, added use of aliases to existing routing tests. Taken the change to unify the failure message as well to this form: routing is required for [" + index + "]/[" + type + "]/[" + id + "] Closes elastic#7145
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The multi_get api and multi_term_vector apis should always return an error when trying to get a document without routing if the routing is set to required. Yet, when using an alias a failure is not returned.
The problem is that the
routingRequiredcheck needs to be done passing in the resolved concrete index.