Simplify reading / writing from and to BlobContainer #7551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| try { | ||
| snapshot = readSnapshot(blobContainer.readBlobFully(snapshotBlobName(snapshotId))); | ||
| try (InputStream stream = blobContainer.openInput(snapshotBlobName(snapshotId))) { | ||
| snapshot = readSnapshot(ByteStreams.toByteArray(stream)); |
There was a problem hiding this comment.
Why not simply this even more by making readSnapshot to accept InputStream instead of array of bytes?
|
Left a couple of comments. Everything else LGTM. |
|
@imotov I pushed a new commit including some more removals can you check it out? |
|
LGTM |
BlobContainer used to provide async APIs which are not used internally. The implementation of these APIs are also not async by nature and neither is any of the pluggable BlobContainers. This commit simplifies the API to a simple input / output stream and reduces the hierarchy of BlobContainer dramatically. NOTE: This is a breaking change! Closes elastic#7551
s1monw
force-pushed
the
cleanup_blob_store
branch
from
3663807
to
7f32e8c
Compare
s1monw
added a commit
that referenced
this pull request
Sep 5, 2014
BlobContainer used to provide async APIs which are not used internally. The implementation of these APIs are also not async by nature and neither is any of the pluggable BlobContainers. This commit simplifies the API to a simple input / output stream and reduces the hierarchy of BlobContainer dramatically. NOTE: This is a breaking change! Closes #7551
s1monw
added a commit
that referenced
this pull request
Sep 8, 2014
BlobContainer used to provide async APIs which are not used internally. The implementation of these APIs are also not async by nature and neither is any of the pluggable BlobContainers. This commit simplifies the API to a simple input / output stream and reduces the hierarchy of BlobContainer dramatically. NOTE: This is a breaking change! Closes #7551
clintongormley
changed the title
This was referenced Sep 12, 2014
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Oct 22, 2014
AWS plugin needs an update because of this change elastic/elasticsearch#7551 Closes elastic#37.
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Oct 30, 2014
AWS plugin needs an update because of this change elastic/elasticsearch#7551 Closes elastic#37.
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Oct 30, 2014
AWS plugin needs an update because of this change elastic/elasticsearch#7551 Closes #37. (cherry picked from commit 6d5ac76) (cherry picked from commit e3028c1)
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Oct 30, 2014
AWS plugin needs an update because of this change elastic/elasticsearch#7551 Closes #37. (cherry picked from commit 6d5ac76)
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
SNAPSHOT_DATA was removed in elastic#7551 but its alias (sd) was not. This was fixed in master with elastic#8643.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlobContainer used to provide async APIs which are not used
internally. The implementation of these APIs are also not async
by nature and neither is any of the pluggable BlobContainers. This
commit simplifies the API to a simple input / output stream and
reduces the hierarchy of BlobContainer dramatically.
NOTE: This is a breaking change!